Variables not being proxied

[jcorbett-sweater]

When I try to use the proxy with a request with variables, the variables aren't forwarded to the graphql server. Here is my code:

proxy_schema = ProxySchema()

proxy_schema.add_remote_schema("http://localhost:8080/graphql/")
final_schema = proxy_schema.get_final_schema()

app = GraphQL(
    final_schema,
    context_value=get_context_value,
    root_value=proxy_schema.root_resolver,
    debug=True,
)

My request:

{"query":" mutation($email:String!,$password:String!) {
	signIn(input:{email:$email,password:$password}) {
		tokens {
			idToken
			accessToken
			refreshToken
		}
	  userErrors {
			__typename
			... on ErrorBase {
				message
			}
		}
	}
}","variables":{"email":"[email protected]","password":"some-password"}}

What the graphql server receives:

{
    "operationName": null,
    "query": "mutation {
  signIn(input: {email: $email, password: $password}) {
    tokens {
      idToken
      accessToken
      refreshToken
    }
    userErrors {
      ... on ErrorBase {
        message
      }
    }
  }
}",
    "variables": {}
  }

[rafalp]

We have quite a few tests for variable handling and all of them are passing currently. I am wondering if issue here is an anonymous operation?

[jcorbett-sweater]

I am not very familiar with the codebase, but in query_filter.py line 69 (method get_schema_query_with_used_variables) you initialize a QueryFilterContext. However nothing ever sets the variables in that context. I hacked something that is working, but I'm sure it's not right. After line 79 I added:

                for variable in operation_node.variable_definitions:
                    context.variables.add(variable.variable.name.value)

That fixes my error, but like I said I doubt that's the right place. Also I haven't tested extensively to make sure it doesn't break other things. I'll have a look at your tests to understand what's different about my case. I tried naming the operation, but it didn't seem to make a difference. I'll post more info as I find it.