Provide different layers' APIs to describeCompat suites #15917
Conversation
github-actions
bot
added
area: tests
|
This is a draft because if we want to go through with this technique, I'll split out the ESNext module changes into their own PR so this isn't so ridiculous to review. Some alternative options we have are:
|
github-actions
bot
added
the
dependencies
|
This generally works. I need to resolve a build error that looks like it has to do with parallelization of compatibility package installation so CI fails on the overall PR, but that doesn't need to be addressed until test-version-utils is converted to ESNext. I'm therefore going to start opening PRs to convert packages depending on test-version-utils to ESNext, before addressing that. |
## Description This makes progress toward #15917 by deleting test-gc-sweep-tests, which is not needed anymore as per @agarwal-navin. PACKAGES.md was updated using `flub check layers --info ./build-tools/packages/build-tools/data/layerInfo.json --md .`.
The issue in CI isn't actually a race condition at all. The |
…5939) ## Description This makes progress toward #15917 by converting `@fluid-example/table-document`'s tests to run esnext modules only. It's not yet feasible to convert the whole package to esnext, as despite being an example package it's currently used by some internal partners. I've therefore just converted the test config to use esnext.
## Description Transitions `@fluid-internal/test-end-to-end-tests` to ESNext modules. This makes progress toward #15917, a planned improvement for `describeCompat`.
packages/test/test-end-to-end-tests/src/test/gc/gcReferenceUpdatesInSummary.spec.ts
Show resolved
Hide resolved
## Description This makes progress toward #15917 by converting @fluid-example/webflow to use esnext modules. This is the most involved update of any of the packages that depend on `@fluid-internal/test-version-utils`, since ESNext modules don't support the `require.extensions` api (they don't support `require`), which was the technique used to make webpack-style CSS imports not blow up when run in a node environment. Instead, it's recommended to use the node esm loader API. Although this API is experimental, it hasn't receive any changes between v16.12 and the node latest (v20.x).
github-actions
bot
removed
the
dependencies
packages/test/test-end-to-end-tests/src/test/gc/gcReferenceUpdatesInSummary.spec.ts
Show resolved
Hide resolved
|
@agarwal-navin I think this is ready to go once our PR builds are healthy again (it passed build/test step, so rest of the pipeline should be green). @justus-camp if you could review general esnext module changes here (and feel free to review the compat testing api changes, they don't require much context to understand), i'd love to get this in today or early next week :) |
⯅ @fluid-example/bundle-size-tests: +30 Bytes
Baseline commit: 54cc669 |
|
ah. I never updated the description on this :(. It's accurate besides the note at the end :P |
## Description This allows e2e tests which create their own data objects to correctly test the same compatibility matrix that other e2e tests do. See #12052 for a historical approach which generally aligns with this one. Note: this is a reapplication of the changes in #15917. Reverting this PR didn't fix the issue, and we have since discovered there was a test reporting issue (fixed in #16098). The intermittent failures are therefore likely due to a flaky test, and not changes related to the esnext switch.
## Description It seems [PR 15917](#15917) missed some changes on the .mocha config files. Sample error: [buildId=169808](https://dev.azure.com/fluidframework/internal/_build/results?buildId=169808&view=results)
## Description This makes progress toward microsoft#15917 by deleting test-gc-sweep-tests, which is not needed anymore as per @agarwal-navin. PACKAGES.md was updated using `flub check layers --info ./build-tools/packages/build-tools/data/layerInfo.json --md .`.
…crosoft#15939) ## Description This makes progress toward microsoft#15917 by converting `@fluid-example/table-document`'s tests to run esnext modules only. It's not yet feasible to convert the whole package to esnext, as despite being an example package it's currently used by some internal partners. I've therefore just converted the test config to use esnext.
Description
This allows e2e tests which create their own data objects to correctly test the same compatibility matrix that other e2e tests do. See #12052 for a historical approach which generally aligns with this one.
Note: CI won't pass on this as I haven't bothered updating the 3 example packages that use test-version-utils.