-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete test-gc-sweep-tests #15943
Delete test-gc-sweep-tests #15943
Conversation
⯅ @fluid-example/bundle-size-tests: +30 Bytes
Baseline commit: 56bd728 |
import { ContainerManager } from "../containerManager"; | ||
import { rootDataObjectWithChildDataObjectFactory } from "../dataObjectWithChildDataObject"; | ||
import { dataObjectWithCounterFactory } from "../dataObjectWithCounter"; | ||
import { mockConfigProvider } from "../mockConfigProvider.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if this would lose typing info for intellisense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope. Typescript looks for .d.ts files adjacent to the js file when using an import statement from an esnext module. You can see their doc has similar syntax.
Overall, my impression is that the ecosystem is a lot more mature w.r.t. supporting fully qualified import paths than the last time I checked. E.g. the changes I had to make to webflow's webpack config to make it understand this import were pretty trivial:
// This ensures that webpack understands fully-specified relative module imports.
// See https://github.com/webpack/webpack/issues/13252 for more discussion.
extensionAlias: {
".js": [".ts", ".tsx", ".js"],
".mjs": [".mts", ".mtsx", ".mjs"],
},
The 2 biggest issues I encountered which I don't have ideal solutions for were:
- VSCode will generate incorrect autocomplete imports. This behavior is configurable via
"typescript.preferences.importModuleSpecifierEnding"
, but I don't think there's a way to tell VSCode to scope the setting to particular subsets of our repo. This issue would go away if we ever convert to full ESNext modules only (which is probably a ways off). - I turned off ESLint's
"import/no-unresolved"
rule for relative imports. We could fix this if we wrote our own ESLint import resolver, but I didn't find one that worked out of the box and IMO the maintenance burden is probably not worth the value the lint rule provides for relative imports.
## Description This makes progress toward microsoft#15917 by deleting test-gc-sweep-tests, which is not needed anymore as per @agarwal-navin. PACKAGES.md was updated using `flub check layers --info ./build-tools/packages/build-tools/data/layerInfo.json --md .`.
Description
This makes progress toward #15917 by deleting test-gc-sweep-tests, which is not needed anymore as per @agarwal-navin.
PACKAGES.md was updated using
flub check layers --info ./build-tools/packages/build-tools/data/layerInfo.json --md .
.