Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish Translation V2.0 #164

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Spanish Translation V2.0 #164

wants to merge 5 commits into from

Conversation

alexsf93
Copy link

Accents have been removed

Accents have been removed
email_change.lang
empire.lang
firstlogin.lang
Spanish translation of:
fleet.lang
FleetMission_MissileAttack.lang
tasks_infobox.lang
texts.lang
topmenu.lang
fleetshortchut.lang
generate_sig.lang
jumpgate.lang
login.lang
logout.lang
stat.lang
Copy link
Owner

@mdziekon mdziekon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, good work! 👍
Just a couple of minor fixes and this Pull Request is ready to be merged.

(As you can see, this took me quite some time to review, so in the follow-up PRs I would recommend keeping them a bit shorter than this. You could also split next translations into separate PRs, as there's usually nothing preventing you from submitting multiple PRs in parallel).


$_Lang['Success_Accepted'] = 'Se ha aceptado la solicitud de amistad';
$_Lang['Success_Refused'] = 'Se ha declinado la solicitud de amistad';
$_Lang['Success_Removed'] = 'Player has been removed from your Friends list';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing translation for this string

$_Lang['sys_attack_title'] = 'Las siguientes flotas han participado en la batalla de %s';

$_Lang['Conv_att_user'] = 'Agresor [color=red][b]%s[/b][/color] %s [%s:%s:%s]';
$_Lang['Conv_tech'] = 'Armas: xXx% | Shields: xXx% | Hull: xXx%';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Shields and Hull words are not translated?


// Inviting other Users

$_Lang['Ally_INV_Title'] = 'Alinza - Envie una invitacion';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$_Lang['Ally_INV_Title'] = 'Alinza - Envie una invitacion';
$_Lang['Ally_INV_Title'] = 'Alianza - Envie una invitacion';

$_Lang['ADM_HandOverTitle'] = 'Alianza - Entrega';

$_Lang['ADM_OnlyOwnerInAlly'] = 'No puedes ceder esta alianza, porque eres su unico miembro!';
$_Lang['ADM_SureHandOver'] = '¿Estas seguro de que quieres ceder esta alianza? \ NCuando la entregues, tu rango se cambiara al rango de tu sucesor.!';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$_Lang['ADM_SureHandOver'] = '¿Estas seguro de que quieres ceder esta alianza? \ NCuando la entregues, tu rango se cambiara al rango de tu sucesor.!';
$_Lang['ADM_SureHandOver'] = '¿Estas seguro de que quieres ceder esta alianza? \n Cuando la entregues, tu rango se cambiara al rango de tu sucesor.!';

$_Lang['fl2_SendButton'] = 'Enviar flota';

$_Lang['fl2_confirm_allypact_attack'] = '¿Estas seguro de que quieres atacar a un jugador que esta en una alianza que tiene un pacto con la alianza en la que estas actualmente?';
$_Lang['fl2_testacctarget'] = '¡Advertencia! \ N¡Las coordenadas del objetivo pertenecen a una de las cuentas de prueba de la Administracion del juego! \n Cualquier accion que involucre a este objetivo sin el permiso del administrador podria resultar en una prohibicion!';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$_Lang['fl2_testacctarget'] = '¡Advertencia! \ N¡Las coordenadas del objetivo pertenecen a una de las cuentas de prueba de la Administracion del juego! \n Cualquier accion que involucre a este objetivo sin el permiso del administrador podria resultar en una prohibicion!';
$_Lang['fl2_testacctarget'] = '¡Advertencia! \n ¡Las coordenadas del objetivo pertenecen a una de las cuentas de prueba de la Administracion del juego! \n Cualquier accion que involucre a este objetivo sin el permiso del administrador podria resultar en una prohibicion!';

@mdziekon mdziekon added pr:translation All pull requests related to the translation process (eg. new language introduction) pr:first_contribution Label for all contributions made for the first time by a new contributor labels Sep 3, 2021
@mdziekon mdziekon mentioned this pull request Sep 3, 2021
admin.lang
\admin\addMoon.lang
\admin\index.php
lostcode.lang
lostpassword.lang
moon_sim.lang
rules.lang
search.lang
Copy link
Owner

@mdziekon mdziekon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes look fine, nothing to fix there.
The old comments still stand, so please fix them before we move further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:first_contribution Label for all contributions made for the first time by a new contributor pr:translation All pull requests related to the translation process (eg. new language introduction)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants