Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bcd info for pattern related svg attributes #36992

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 44 additions & 33 deletions files/en-us/web/svg/attribute/height/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,15 @@
title: height
slug: Web/SVG/Attribute/height
page-type: svg-attribute
spec-urls:
- https://drafts.fxtf.org/filter-effects/#element-attrdef-filter-height
- https://drafts.fxtf.org/filter-effects/#element-attrdef-filter-primitive-height
- https://drafts.fxtf.org/css-masking-1/#element-attrdef-mask-height
- https://svgwg.org/svg2-draft/geometry.html#Sizing
- https://svgwg.org/svg2-draft/pservers.html#PatternElementHeightAttribute
browser-compat:
- svg.elements.filter.height
- svg.elements.foreignObject.height
- svg.elements.image.height
- svg.elements.mask.height
- svg.elements.pattern.height
- svg.elements.rect.height
- svg.elements.svg.height
- svg.elements.use.height
Comment on lines +6 to +13
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the value in having all of these? In Web APIs it was agreed that we definitely should not add all the cases, say, of where a global might be used.

The reasoning was that it it add a lot of useless information to the page - for example, if you're interested this information, where are you looking. I'd say you would look in the element in which it is used. I'm never going to look and say - hey, the mask support height from version X, let's go use the mask now. Make sense? I'd revert.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skyclouds2001 The point of this PR seems to be to add these BCD changes. I don't think these are actually unhelpful, but it may be that the broader team disagrees. Where's the agreement for this approach?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skyclouds2001 The point of this PR seems to be to add these BCD changes. I don't think these are actually unhelpful, but it may be that the broader team disagrees. Where's the agreement for this approach?

no, maybe, I guess

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to start with an agreed template #36992 (comment)

---

{{SVGRef}}
Expand Down Expand Up @@ -42,7 +45,7 @@ You can use this attribute with the following SVG elements:
- {{SVGElement('svg')}}
- {{SVGElement('use')}}

## Example
## Examples
skyclouds2001 marked this conversation as resolved.
Show resolved Hide resolved

```css hidden
html,
Expand All @@ -61,9 +64,13 @@ svg {
</svg>
```

{{EmbedLiveSample("Example", '100%', 200)}}
{{EmbedLiveSample("Examples", '100%', 200)}}
hamishwillee marked this conversation as resolved.
Show resolved Hide resolved
skyclouds2001 marked this conversation as resolved.
Show resolved Hide resolved

## feBlend
## Elements

You can use this attribute with the SVG elements described in the sections below.

### `<feBlend>`

For {{SVGElement('feBlend')}}, `height` defines the vertical length for the rendering area of the primitive.

Expand Down Expand Up @@ -94,7 +101,7 @@ For {{SVGElement('feBlend')}}, `height` defines the vertical length for the rend
</tbody>
</table>

## feColorMatrix
### `<feColorMatrix>`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where was this heading approach agreed? I like it, but if we're using styling and tag markup in the headings this should be agreed and captured in the SVG page template (it might be, I haven't checked)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at present there is only a page template for svg element; and there is no page template for svg attrbute

Copy link
Collaborator

@hamishwillee hamishwillee Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about you create an SVG attribute template in a PR the way you want it, and then invite people to discuss? Then we can have agreement on things like #36992 (comment) and something that others can match going forward.

Thoughts?

If you prefer I could create the template on Monday?


For {{SVGElement('feColorMatrix')}}, `height` defines the vertical length for the rendering area of the primitive.

Expand Down Expand Up @@ -125,7 +132,7 @@ For {{SVGElement('feColorMatrix')}}, `height` defines the vertical length for th
</tbody>
</table>

## feComponentTransfer
### `<feComponentTransfer>`

For {{SVGElement('feComponentTransfer')}}, `height` defines the vertical length for the rendering area of the primitive.

Expand Down Expand Up @@ -156,7 +163,7 @@ For {{SVGElement('feComponentTransfer')}}, `height` defines the vertical length
</tbody>
</table>

## feComposite
### `<feComposite>`

For {{SVGElement('feComposite')}}, `height` defines the vertical length for the rendering area of the primitive.

Expand Down Expand Up @@ -187,7 +194,7 @@ For {{SVGElement('feComposite')}}, `height` defines the vertical length for the
</tbody>
</table>

## feConvolveMatrix
### `<feConvolveMatrix>`

For {{SVGElement('feConvolveMatrix')}}, `height` defines the vertical length for the rendering area of the primitive.

Expand Down Expand Up @@ -218,7 +225,7 @@ For {{SVGElement('feConvolveMatrix')}}, `height` defines the vertical length for
</tbody>
</table>

## feDiffuseLighting
### `<feDiffuseLighting>`

For {{SVGElement('feDiffuseLighting')}}, `height` defines the vertical length for the rendering area of the primitive.

Expand Down Expand Up @@ -249,7 +256,7 @@ For {{SVGElement('feDiffuseLighting')}}, `height` defines the vertical length fo
</tbody>
</table>

## feDisplacementMap
### `<feDisplacementMap>`

For {{SVGElement('feDisplacementMap')}}, `height` defines the vertical length for the rendering area of the primitive.

Expand Down Expand Up @@ -280,7 +287,7 @@ For {{SVGElement('feDisplacementMap')}}, `height` defines the vertical length fo
</tbody>
</table>

## feDropShadow
### `<feDropShadow>`

For {{SVGElement('feDropShadow')}}, `height` defines the vertical length for the rendering area of the primitive.

Expand Down Expand Up @@ -311,7 +318,7 @@ For {{SVGElement('feDropShadow')}}, `height` defines the vertical length for the
</tbody>
</table>

## feFlood
### `<feFlood>`

For {{SVGElement('feFlood')}}, `height` defines the vertical length for the rendering area of the primitive.

Expand Down Expand Up @@ -342,7 +349,7 @@ For {{SVGElement('feFlood')}}, `height` defines the vertical length for the rend
</tbody>
</table>

## feGaussianBlur
### `<feGaussianBlur>`

For {{SVGElement('feGaussianBlur')}}, `height` defines the vertical length for the rendering area of the primitive.

Expand Down Expand Up @@ -373,7 +380,7 @@ For {{SVGElement('feGaussianBlur')}}, `height` defines the vertical length for t
</tbody>
</table>

## feImage
### `<feImage>`

For {{SVGElement('feImage')}}, `height` defines the vertical length for the rendering area of the primitive.

Expand Down Expand Up @@ -404,7 +411,7 @@ For {{SVGElement('feImage')}}, `height` defines the vertical length for the rend
</tbody>
</table>

## feMerge
### `<feMerge>`

For {{SVGElement('feMerge')}}, `height` defines the vertical length for the rendering area of the primitive.

Expand Down Expand Up @@ -435,7 +442,7 @@ For {{SVGElement('feMerge')}}, `height` defines the vertical length for the rend
</tbody>
</table>

## feMorphology
### `<feMorphology>`

For {{SVGElement('feMorphology')}}, `height` defines the vertical length for the rendering area of the primitive.

Expand Down Expand Up @@ -466,7 +473,7 @@ For {{SVGElement('feMorphology')}}, `height` defines the vertical length for the
</tbody>
</table>

## feOffset
### `<feOffset>`

For {{SVGElement('feOffset')}}, `height` defines the vertical length for the rendering area of the primitive.

Expand Down Expand Up @@ -497,7 +504,7 @@ For {{SVGElement('feOffset')}}, `height` defines the vertical length for the ren
</tbody>
</table>

## feSpecularLighting
### `<feSpecularLighting>`

For {{SVGElement('feSpecularLighting')}}, `height` defines the vertical length for the rendering area of the primitive.

Expand Down Expand Up @@ -528,7 +535,7 @@ For {{SVGElement('feSpecularLighting')}}, `height` defines the vertical length f
</tbody>
</table>

## feTile
### `<feTile>`

For {{SVGElement('feTile')}}, `height` defines the vertical length for the rendering area of the primitive.

Expand Down Expand Up @@ -559,7 +566,7 @@ For {{SVGElement('feTile')}}, `height` defines the vertical length for the rende
</tbody>
</table>

## feTurbulence
### `<feTurbulence>`

For {{SVGElement('feTurbulence')}}, `height` defines the vertical length for the rendering area of the primitive.

Expand Down Expand Up @@ -590,7 +597,7 @@ For {{SVGElement('feTurbulence')}}, `height` defines the vertical length for the
</tbody>
</table>

## filter
### `<filter>`

For {{SVGElement('filter')}}, `height` defines the vertical length for the rendering area of the filter.

Expand Down Expand Up @@ -621,7 +628,7 @@ For {{SVGElement('filter')}}, `height` defines the vertical length for the rende
</tbody>
</table>

## foreignObject
### `<foreignObject>`

For {{SVGElement('foreignObject')}}, `height` defines the vertical length for the rendering area for the referenced document.

Expand Down Expand Up @@ -656,7 +663,7 @@ For {{SVGElement('foreignObject')}}, `height` defines the vertical length for th
> [!NOTE]
> Starting with SVG2, `height` is a _Geometry Property_ meaning this attribute can also be used as a CSS property for `<foreignObject>`.

## image
### `<image>`

For {{SVGElement('image')}}, `height` defines the vertical length for the image.

Expand Down Expand Up @@ -691,7 +698,7 @@ For {{SVGElement('image')}}, `height` defines the vertical length for the image.
> [!NOTE]
> Starting with SVG2, `height` is a _Geometry Property_ meaning this attribute can also be used as a CSS property for images.

## mask
### `<mask>`

For {{SVGElement('mask')}}, `height` defines the vertical length of its area of effect. The exact effect of this attribute is influenced by the {{SVGAttr('maskUnits')}} attribute.

Expand Down Expand Up @@ -722,7 +729,7 @@ For {{SVGElement('mask')}}, `height` defines the vertical length of its area of
</tbody>
</table>

## pattern
### `<pattern>`

For {{SVGElement('pattern')}}, `height` defines the vertical length of the tile pattern. The exact effect of this attribute is influenced by the {{SVGAttr('patternUnits')}} and {{SVGAttr('patternTransform')}} attributes.

Expand All @@ -747,7 +754,7 @@ For {{SVGElement('pattern')}}, `height` defines the vertical length of the tile
</tbody>
</table>

## rect
### `<rect>`

For {{SVGElement('rect')}}, `height` defines the vertical length for the rectangle.

Expand Down Expand Up @@ -782,7 +789,7 @@ For {{SVGElement('rect')}}, `height` defines the vertical length for the rectang
> [!NOTE]
> Starting with SVG2, `height` is a _Geometry Property_ meaning this attribute can also be used as a CSS property for rectangles.

## svg
### `<svg>`

For {{SVGElement('svg')}}, `height` defines the vertical length for the rendering area of the SVG viewport.

Expand Down Expand Up @@ -820,7 +827,7 @@ For {{SVGElement('svg')}}, `height` defines the vertical length for the renderin
> [!NOTE]
> Starting with SVG2, `height` is a _Geometry Property_ meaning this attribute can also be used as a CSS property for `<svg>`.

## use
### `<use>`

For {{SVGElement('use')}}, `height` defines the vertical length for the referenced element.

Expand Down Expand Up @@ -860,3 +867,7 @@ For {{SVGElement('use')}}, `height` defines the vertical length for the referenc
## Specifications

{{Specifications}}

## Browser compatibility

{{Compat}}
6 changes: 5 additions & 1 deletion files/en-us/web/svg/attribute/href/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ browser-compat:
- svg.elements.animate.href
- svg.elements.animateMotion.href
- svg.elements.animateTransform.href
- svg.elements.cursor.href
- svg.elements.feImage.href
- svg.elements.image.href
- svg.elements.linearGradient.href
Expand All @@ -32,6 +33,7 @@ You can use this attribute with the following SVG elements:
- {{SVGElement("animate")}}
- {{SVGElement("animateMotion")}}
- {{SVGElement("animateTransform")}}
- {{SVGElement("cursor")}}
- {{SVGElement("feImage")}}
- {{SVGElement("image")}}
- {{SVGElement("linearGradient")}}
Expand Down Expand Up @@ -63,7 +65,9 @@ svg {

{{EmbedLiveSample("Example", "320", "100")}}

## In SVG
## Elements

You can use this attribute with the SVG elements described in the sections below.

### a

Expand Down
Loading