Add bcd info for pattern related svg attributes #36992
Conversation
github-actions
bot
added
Content:SVG
Preview URLs (8 pages)
Flaws (1)Note! 7 documents with no flaws that don't need to be listed. 🎉 URL:
(comment last updated: 2024-12-20 03:08:06) |
skyclouds2001
requested review from
hamishwillee
and removed request for
a team
| @@ -94,7 +101,7 @@ For {{SVGElement('feBlend')}}, `height` defines the vertical length for the rend | |||
| </tbody> | |||
| </table> | |||
|
|
|||
| ## feColorMatrix | |||
| ### `<feColorMatrix>` | |||
There was a problem hiding this comment.
Where was this heading approach agreed? I like it, but if we're using styling and tag markup in the headings this should be agreed and captured in the SVG page template (it might be, I haven't checked)
There was a problem hiding this comment.
at present there is only a page template for svg element; and there is no page template for svg attrbute
There was a problem hiding this comment.
How about you create an SVG attribute template in a PR the way you want it, and then invite people to discuss? Then we can have agreement on things like #36992 (comment) and something that others can match going forward.
Thoughts?
If you prefer I could create the template on Monday?
| - svg.elements.filter.height | ||
| - svg.elements.foreignObject.height | ||
| - svg.elements.image.height | ||
| - svg.elements.mask.height | ||
| - svg.elements.pattern.height | ||
| - svg.elements.rect.height | ||
| - svg.elements.svg.height | ||
| - svg.elements.use.height |
There was a problem hiding this comment.
What's the value in having all of these? In Web APIs it was agreed that we definitely should not add all the cases, say, of where a global might be used.
The reasoning was that it it add a lot of useless information to the page - for example, if you're interested this information, where are you looking. I'd say you would look in the element in which it is used. I'm never going to look and say - hey, the mask support height from version X, let's go use the mask now. Make sense? I'd revert.
There was a problem hiding this comment.
@skyclouds2001 The point of this PR seems to be to add these BCD changes. I don't think these are actually unhelpful, but it may be that the broader team disagrees. Where's the agreement for this approach?
There was a problem hiding this comment.
@skyclouds2001 The point of this PR seems to be to add these BCD changes. I don't think these are actually unhelpful, but it may be that the broader team disagrees. Where's the agreement for this approach?
no, maybe, I guess
There was a problem hiding this comment.
Best to start with an agreed template #36992 (comment)
| - https://drafts.fxtf.org/filter-effects/#element-attrdef-feimage-preserveaspectratio | ||
| - https://svgwg.org/svg2-draft/coords.html#PreserveAspectRatioAttribute | ||
| browser-compat: | ||
| - svg.elements.svg.preserveAspectRatio |
There was a problem hiding this comment.
Ditto to above comment, and for all the others.
Description
add browser-compat key and Browser compatibility section for adding bcd info
other include some style adjust
Motivation
Additional details
Related issues and pull requests