Add support for MSC4717: service members 🫡

[poljar]

Depends on #4228, only the second commit here is relevant.

This adds support for service members to be excluded from the room display name calculation logic as described in MSC4717.

[bnjbvr]

Looks good on principle, thanks! Should we move the dependent PR forward first? (If so: feel free to steal the review on it, I have lost context, and I'm not sure if it's ready for review or if it's expecting more work)

[bnjbvr]

(Removed review request until the dependent PR is merged first.)

[poljar]

(Removed review request until the dependent PR is merged first.)

Why?

[bnjbvr]

Because OP reads:

Depends on #4228

[poljar]

Because OP reads:

Depends on #4228

Ok but you reviewed the PR event though OP read that same message. Then I addressed all of your review comments except one.

Now you're telling me that you won't review it because OP reads this message. I'm asking why you changed your mind and why do you think that #4228 needs to be merged before this one is reviewed?

They are conceptually unrelated, they are tied together because Ruma had breaking changes.

On the topic of #4228, seems that the author also addressed your concerns but is as well waiting on your review.

[bnjbvr]

If the code i need to review is meant to change, and that change is expected in an obvious way (in this case, because we'll update the ref to Ruma's source), then I prefer to wait on the final version of the code before doing the review. In any case, feel free to steal the review of the dependent PR; I am not bound to it in any ways, and I would appreciate the support in sharing the review load 🙏

[codecov]

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.17%. Comparing base (ee30008) to head (97439b3).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/matrix-sdk-base/src/rooms/normal.rs	95.83%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4335      +/-   ##
==========================================
+ Coverage   85.15%   85.17%   +0.01%     
==========================================
  Files         280      280              
  Lines       30861    30879      +18     
==========================================
+ Hits        26281    26301      +20     
+ Misses       4580     4578       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bnjbvr]

Thanks! Only reviewed the second commit, assuming we'll wait for the dependent PR to be first reviewed and merged before landing this.