Ensure that we request the correct state event for the service members to work correctly #4407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poljar
requested review from
Hywan and
a team
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4407 +/- ##
==========================================
- Coverage 85.29% 85.27% -0.02%
==========================================
Files 282 282
Lines 31178 31186 +8
==========================================
+ Hits 26592 26594 +2
- Misses 4586 4592 +6 ☔ View full report in Codecov by Sentry. |
poljar
force-pushed
the
poljar/fix-service-members-sliding-sync
branch
from
bb0baf0 to
9c1d950
Compare
This state event allows us to correctly calculate the room display name according to MSC4171. MSC: matrix-org/matrix-spec-proposals#4171
…ned members This patch fixes an edge case where the member is alone in the room with a service member. We already subtracted the number of service members in the case we calculated the room summary ourselves, but we did not do so when the server provided the room summary. This lead to the room, instead of being called `Empty`, being called `Foo and N others`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot that under sliding sync we won't have access to all state events, which meant that #4335 never got working.
The first commit adds the relevant event to the required state for the UI crate.
The second commit fixes another edge case in the case where we homeserver does provide a room summary containing service members in the heroes and thus in the joined members count.