Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1654

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Develop #1654

Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 53 additions & 2 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,54 @@
from __future__ import annotations


class Distance:
# Write your code here
pass

def __init__(self, km: float) -> None:
self.km = km

def __str__(self) -> str:
return f"Distance: {self.km} kilometers."

def __repr__(self) -> str:
return f"Distance(km={self.km})"

def __add__(self, other: Distance) -> Distance:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type hint for the other parameter in the __add__ method should allow for both Distance and float types, as the method logic handles both cases. Consider changing it to Union[Distance, float].

km = other.km if isinstance(other, Distance) else other
return Distance(
km=self.km + km
)

def __iadd__(self, other: Distance) -> Distance:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the __add__ method, the type hint for the other parameter in the __iadd__ method should allow for both Distance and float types. Consider using Union[Distance, float].

km = other.km if isinstance(other, Distance) else other
self.km += km
return self

def __mul__(self, mul: float) -> Distance:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mul parameter in the __mul__ method should be annotated as float or int, as multiplication with an integer is also valid.

return Distance(
km=self.km * mul
)

def __truediv__(self, div: float) -> Distance:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The div parameter in the __truediv__ method should be annotated as float or int, as division by an integer is also valid.

return Distance(
km=round(self.km / div, 2)
)

def __lt__(self, other: Distance) -> bool:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type hint for the other parameter in the __lt__ method should allow for both Distance and float types, as the method logic handles both cases. Consider changing it to Union[Distance, float].

km = other.km if isinstance(other, Distance) else other
return self.km < km

def __gt__(self, other: Distance) -> bool:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type hint for the other parameter in the __gt__ method should allow for both Distance and float types. Consider using Union[Distance, float].

km = other.km if isinstance(other, Distance) else other
return self.km > km

def __eq__(self, other: Distance) -> bool:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type hint for the other parameter in the __eq__ method should allow for both Distance and float types. Consider using Union[Distance, float].

km = other.km if isinstance(other, Distance) else other
return self.km == km

def __le__(self, other: Distance) -> bool:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type hint for the other parameter in the __le__ method should allow for both Distance and float types. Consider using Union[Distance, float].

km = other.km if isinstance(other, Distance) else other
return self.km <= km

def __ge__(self, other: Distance) -> bool:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type hint for the other parameter in the __ge__ method should allow for both Distance and float types. Consider using Union[Distance, float].

km = other.km if isinstance(other, Distance) else other
return self.km >= km
Loading