Develop #1654
Develop #1654
Conversation
There was a problem hiding this comment.
Great job on implementing the Distance class! 🎉 Your code meets the task requirements and constraints effectively. While there are some suggestions regarding type annotations, they don't impact the functionality. Keep up the good work and consider refining those type hints for even better clarity in the future! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: Distance) -> Distance: |
There was a problem hiding this comment.
The type hint for the other parameter in the __add__ method should allow for both Distance and float types, as the method logic handles both cases. Consider changing it to Union[Distance, float].
| km=self.km + km | ||
| ) | ||
|
|
||
| def __iadd__(self, other: Distance) -> Distance: |
There was a problem hiding this comment.
Similar to the __add__ method, the type hint for the other parameter in the __iadd__ method should allow for both Distance and float types. Consider using Union[Distance, float].
| self.km += km | ||
| return self | ||
|
|
||
| def __mul__(self, mul: float) -> Distance: |
There was a problem hiding this comment.
The mul parameter in the __mul__ method should be annotated as float or int, as multiplication with an integer is also valid.
| km=self.km * mul | ||
| ) | ||
|
|
||
| def __truediv__(self, div: float) -> Distance: |
There was a problem hiding this comment.
The div parameter in the __truediv__ method should be annotated as float or int, as division by an integer is also valid.
| km=round(self.km / div, 2) | ||
| ) | ||
|
|
||
| def __lt__(self, other: Distance) -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter in the __lt__ method should allow for both Distance and float types, as the method logic handles both cases. Consider changing it to Union[Distance, float].
| km = other.km if isinstance(other, Distance) else other | ||
| return self.km < km | ||
|
|
||
| def __gt__(self, other: Distance) -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter in the __gt__ method should allow for both Distance and float types. Consider using Union[Distance, float].
| km = other.km if isinstance(other, Distance) else other | ||
| return self.km > km | ||
|
|
||
| def __eq__(self, other: Distance) -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter in the __eq__ method should allow for both Distance and float types. Consider using Union[Distance, float].
| km = other.km if isinstance(other, Distance) else other | ||
| return self.km == km | ||
|
|
||
| def __le__(self, other: Distance) -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter in the __le__ method should allow for both Distance and float types. Consider using Union[Distance, float].
| km = other.km if isinstance(other, Distance) else other | ||
| return self.km <= km | ||
|
|
||
| def __ge__(self, other: Distance) -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter in the __ge__ method should allow for both Distance and float types. Consider using Union[Distance, float].
No description provided.