Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1646

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Develop #1646

Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 66 additions & 2 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,67 @@
class Distance:
# Write your code here
pass
def __init__(self, km: int) -> None:
self.km = km

def __repr__(self) -> str:
return f"Distance(km={self.km})"

def __str__(self) -> str:
return f"Distance: {self.km} kilometers."

def __add__(self, other: int) -> "Distance":

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type hint for the other parameter should include Distance as well, i.e., Union[Distance, int, float].

if isinstance(other, Distance):
return Distance(
km=self.km + other.km
)
elif isinstance(other, (int, float)):
return Distance(
km=self.km + other
)

def __iadd__(self, other: int) -> "Distance":

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type hint for the other parameter should include Distance as well, i.e., Union[Distance, int, float].

if isinstance(other, Distance):
self.km += other.km
return self
elif isinstance(other, (int, float)):
self.km += other
return self

def __mul__(self, other: int) -> "Distance":

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __mul__ method should return a new Distance instance instead of modifying the current instance. Consider using return Distance(self.km * other).

if isinstance(other, (int, float)):
self.km *= other
return self

def __truediv__(self, other: int) -> "Distance":

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __truediv__ method should return a new Distance instance instead of modifying the current instance. Consider using return Distance(round(self.km / other, 2)).

if isinstance(other, (int, float)):
self.km = round(self.km / other, 2)
return self

def __lt__(self, other: int) -> bool:
if isinstance(other, Distance):
return self.km < other.km
elif isinstance(other, (int, float)):
return self.km < other

def __gt__(self, other: int) -> bool:
if isinstance(other, Distance):
return self.km > other.km
elif isinstance(other, (int, float)):
return self.km > other

def __eq__(self, other: int) -> bool:
if isinstance(other, Distance):
return self.km == other.km
elif isinstance(other, (int, float)):
return self.km == other

def __le__(self, other: int) -> bool:
if isinstance(other, Distance):
return self.km <= other.km
elif isinstance(other, (int, float)):
return self.km <= other

def __ge__(self, other: int) -> bool:
if isinstance(other, Distance):
return self.km >= other.km
elif isinstance(other, (int, float)):
return self.km >= other
Loading