Develop #1646
Develop #1646
Conversation
There was a problem hiding this comment.
Great job on implementing the Distance class! 🎉 Your code meets the task requirements and constraints, and you've done well with the initialization, representation, arithmetic, and comparison operations. However, there are a few areas for improvement:
-
Type Hints: Ensure the type hints for the
__add__,__iadd__,__mul__, and__truediv__methods includeDistanceobjects and numeric types, i.e.,Union[Distance, int, float]. -
Return New Instances: The
__mul__and__truediv__methods should return newDistanceinstances instead of modifying the current instance. Consider usingreturn Distance(self.km * other)for multiplication andreturn Distance(round(self.km / other, 2))for division.
These changes will enhance the functionality and maintainability of your code. Keep up the good work, and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| def __str__(self) -> str: | ||
| return f"Distance: {self.km} kilometers." | ||
|
|
||
| def __add__(self, other: int) -> "Distance": |
There was a problem hiding this comment.
The type hint for the other parameter should include Distance as well, i.e., Union[Distance, int, float].
| km=self.km + other | ||
| ) | ||
|
|
||
| def __iadd__(self, other: int) -> "Distance": |
There was a problem hiding this comment.
The type hint for the other parameter should include Distance as well, i.e., Union[Distance, int, float].
| self.km += other | ||
| return self | ||
|
|
||
| def __mul__(self, other: int) -> "Distance": |
There was a problem hiding this comment.
The __mul__ method should return a new Distance instance instead of modifying the current instance. Consider using return Distance(self.km * other).
| self.km *= other | ||
| return self | ||
|
|
||
| def __truediv__(self, other: int) -> "Distance": |
There was a problem hiding this comment.
The __truediv__ method should return a new Distance instance instead of modifying the current instance. Consider using return Distance(round(self.km / other, 2)).
No description provided.