Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Python version to 3.10 in documentation validation workflow #625

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

lgarber-akamai
Copy link
Contributor

@lgarber-akamai lgarber-akamai commented Nov 21, 2024

📝 Description

NOTE: This changes from the PR will not apply to workflows on this PR until it has been merged to main.

This pull request pins the Python version in the documentation validation workflow to 3.10, which matches the default version defined in our integration test workflow.

This is necessary because Ansible 11.0.0 does not support < Python 3.11 but has some minor documentation differences when compared against 10.x.x, causing our documentation validation workflows to fail.

In the future we should consider bumping the minimum Python version of this repo to match Ansible's minimum Python version.

@lgarber-akamai lgarber-akamai added the repo-ci-improvement for improvements in the repository or CI workflow in the changelog. label Nov 21, 2024
@lgarber-akamai lgarber-akamai requested a review from a team as a code owner November 21, 2024 17:17
@lgarber-akamai lgarber-akamai requested review from zliang-akamai and ykim-akamai and removed request for a team November 21, 2024 17:17
Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zliang-akamai
Copy link
Member

BTW let's backlog a ticket for upgrading Python and Ansible?

If Ansible 11 has a different docs format, I wonder if it's backward compatible with Ansible < 11

Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for looking into this

@lgarber-akamai lgarber-akamai merged commit 3b07f45 into linode:dev Nov 25, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo-ci-improvement for improvements in the repository or CI workflow in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants