Use linode_api4 API error handling logic; remove format_api_error(...) helper #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarber-akamai
added
the
improvement
lgarber-akamai
requested review from
zliang-akamai and
ezilber-akamai
and removed request for
a team
|
The documentation validation error will be resolved in #625 |
ezilber-akamai
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request updates the top-level API error formatting logic to use the formatting logic provided by the Python SDK, which produces errors with more meaningful information (request method, URL, etc.):
This pull request also bumps the minimum
linode_api4version from5.22.0to5.24.0.✔️ How to Test
The following test steps assume you have pulled down this PR locally and run
make deps.Integration Testing