Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-3336 Make Echo ping of web socket optional #3355

Merged

Conversation

tddang-linagora
Copy link
Contributor

@tddang-linagora tddang-linagora commented Dec 16, 2024

Issue

Demo

Screen.Recording.2024-12-17.at.10.47.24.mov

Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3355.

Copy link
Member

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misses documentation on how to turn this on and off and default value.

I am a flutter outsider.

If you wish me to do that for you please document it!

@tddang-linagora
Copy link
Contributor Author

Misses documentation on how to turn this on and off and default value.

I am a flutter outsider.

If you wish me to do that for you please document it!

In case you missed the adr no. 56 of this PR

- Echo ping will still be left as an option in `env.file` through `WS_ECHO_PING`
  - Set it to `true` if you want to use Echo ping
  - Set it to `false` or left it as is if you don't want to use Echo ping

@dab246
Copy link
Member

dab246 commented Dec 17, 2024

  • Add WS_ECHO_PING in env.file

@dab246
Copy link
Member

dab246 commented Dec 17, 2024

  • Please attach demo video to verify it still work well.

@hoangdat
Copy link
Member

I tested in mail.lin-saas.dev, to keep it all night. Still work well.

hoangdat
hoangdat previously approved these changes Dec 17, 2024
dab246
dab246 previously approved these changes Dec 18, 2024
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoangdat hoangdat changed the base branch from master to maintenance-v0.14.2 December 18, 2024 04:43
@hoangdat hoangdat dismissed stale reviews from dab246 and themself December 18, 2024 04:43

The base branch was changed.

@tddang-linagora tddang-linagora force-pushed the enhancement/TF-3336-ws-ping-improvement branch from 86addd0 to 6c651d3 Compare December 18, 2024 04:48
@tddang-linagora tddang-linagora force-pushed the enhancement/TF-3336-ws-ping-improvement branch from 6c651d3 to 2f8e508 Compare December 18, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants