-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF-3336 Make Echo ping of web socket optional #3355
TF-3336 Make Echo ping of web socket optional #3355
Conversation
This PR has been deployed to https://linagora.github.io/tmail-flutter/3355. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Misses documentation on how to turn this on and off and default value.
I am a flutter outsider.
If you wish me to do that for you please document it!
In case you missed the adr no. 56 of this PR - Echo ping will still be left as an option in `env.file` through `WS_ECHO_PING`
- Set it to `true` if you want to use Echo ping
- Set it to `false` or left it as is if you don't want to use Echo ping |
|
|
I tested in mail.lin-saas.dev, to keep it all night. Still work well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The base branch was changed.
86addd0
to
6c651d3
Compare
6c651d3
to
2f8e508
Compare
Issue
Demo
Screen.Recording.2024-12-17.at.10.47.24.mov