-
Notifications
You must be signed in to change notification settings - Fork 78
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
TF-3336 Make Echo ping of web socket optional
- Loading branch information
1 parent
050a885
commit 6c651d3
Showing
5 changed files
with
44 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# 56. Web Socket Ping Strategy | ||
|
||
Date: 2024-12-16 | ||
|
||
## Status | ||
|
||
Accepted | ||
|
||
## Context | ||
|
||
- Echo ping method takes too much resources from the server | ||
- Server implemented ping frame | ||
|
||
## Decision | ||
|
||
- Twake Mail no longer have to implement Echo ping | ||
- Browser will automatically send pong frame as default implementation | ||
- Echo ping will still be left as an option in `env.file` through `WS_ECHO_PING` | ||
- Set it to `true` if you want to use Echo ping | ||
- Set it to `false` or left it as is if you don't want to use Echo ping | ||
|
||
## Consequences | ||
|
||
- Server resources used will be reduced |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
## Configuration Web Socket Echo Ping | ||
|
||
### Context | ||
- Echo ping method is optional | ||
### How to config | ||
In [env.file]: | ||
- If you want to use Echo ping: | ||
```WS_ECHO_PING=true``` | ||
- If you don't want to use Echo ping: | ||
```WS_ECHO_PING=false``` | ||
or | ||
```WS_ECHO_PING=``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters