fix(hole-punch): Add support for arm64 architecture #4687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomrsantos
changed the title
4 tasks
thomaseizinger
changed the base branch from
master
to
feat/hole-punching-tests
|
Did the same as in libp2p/test-plans#311 |
|
This pull request has merge conflicts. Could you please resolve them @diegomrsantos? 🙏 |
diegomrsantos
force-pushed
the
fix/hole-punching-arm64-support
branch
from
6f52d91 to
a7ceded
Compare
diegomrsantos
force-pushed
the
fix/hole-punching-arm64-support
branch
from
a7ceded to
c945f8d
Compare
thomaseizinger
merged commit 2c23215
into
libp2p:feat/hole-punching-tests
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for the arm64 architecture when building and running hole-punching tests. Currently, it’s not possible to run the tests on this architecture.
Related libp2p/test-plans#311, libp2p/test-plans#304
Notes & open questions
#4549 (comment)
Change checklist