Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add automated hole-punch tests #4549

Merged
merged 179 commits into from
Oct 25, 2023
Merged

ci: add automated hole-punch tests #4549

merged 179 commits into from
Oct 25, 2023

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Sep 25, 2023 •
edited
Loading

Description

Related: libp2p/test-plans#304.

Attributions

Co-authored-by: diegomrsantos [email protected]

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

thomaseizinger and others added 30 commits July 5, 2023 13:19
@thomaseizinger
Initial routes working
d6b0647
@thomaseizinger
Some stuff works
5bfb526
@thomaseizinger
Switch to debian and manual nft routes
1fa84b6
@thomaseizinger
Fix typo regarding IP forwarding
5781b34
@thomaseizinger
Only assign single IP to interface
a583cbf
@thomaseizinger
Use default routes instead
b6f6587
@thomaseizinger
Map to correct IP in NAT
42453b8
@thomaseizinger
Don't enable IP forwarding when not necessary
e63a8a8
@thomaseizinger
Introduce dedicated internet namespace
93034f1
@thomaseizinger
Assign IPs in same subnet
5c99a98
@thomaseizinger
WIP completely new approach
13e087b
@thomaseizinger
Return from client
49c3196
@thomaseizinger
Remove old scripts
75db11f
@thomaseizinger
Add relay test module
4d28d38
@thomaseizinger
Add hole punching tests to CI
cc69536
@thomaseizinger
Undo dockerignore change
a072c94
@thomaseizinger
Fix linter warnings
e19ddf0
@tcoratger @thomaseizinger
feat(core): add logs for OrTransport when trying addresses
37dddd4 
Currently, when trying addresses in `listen_on` via `OrTransport`, there are no logs to facilitate debugging. This PR corrects that by providing adequate logs via `std::any::type_name` method.

Resolves #4072.

Pull-Request: #4133.
@mxinden @thomaseizinger
docs(swarm): document Swarm::external_addresses
7d2fff6 
Pull-Request: #4159.
@b-zee @thomaseizinger
fix(swarm): external address candidate only after address translation
e29b5a8 
Pull-Request: #4158.
@mxinden @thomaseizinger
fix(core/choice): log on dial and fix listen log
752bf13 
- Fixes typo in `<OrTransport as Transport>::listen_on` using the word "dial" instead of "listen_on".
- Adds logging to `<OrTransport as Transport>::dial`.

Follow-up to #4133

Pull-Request: #4164.
@dariusc93 @thomaseizinger
chore: Update CHANGELOG.md
be11ca6 
Add missing PR to CHANGELOG.md

Pull-Request: #4163.
@dependabot @thomaseizinger
deps: bump tokio from 1.28.2 to 1.29.1
4520a20 
Pull-Request: #4148.
@dependabot @thomaseizinger
deps: bump regex from 1.8.4 to 1.9.1
22551c1 
Pull-Request: #4170.
@dependabot @thomaseizinger
deps: bump smallvec from 1.10.0 to 1.11.0
ac942f2 
Pull-Request: #4171.
@dependabot @thomaseizinger
deps: bump serde_json from 1.0.99 to 1.0.100
42b3bc7 
Pull-Request: #4172.
@dependabot @thomaseizinger
deps: bump async-trait from 0.1.69 to 0.1.71
4701040 
Pull-Request: #4175.
@dependabot @thomaseizinger
deps: bump syn from 2.0.23 to 2.0.25
95a02cc 
Pull-Request: #4176.
@dependabot @thomaseizinger
deps: bump webpki-roots from 0.23.1 to 0.24.0
d50280f 
Pull-Request: #4177.
@dependabot @thomaseizinger
deps: bump clap from 4.3.10 to 4.3.11
0612907 
Pull-Request: #4178.
@thomaseizinger thomaseizinger mentioned this pull request Oct 25, 2023
Merged
@mergify

This comment was marked as resolved.

Sign in to view
@thomaseizinger thomaseizinger mentioned this pull request Oct 25, 2023
Merged
4 tasks
@thomaseizinger
Copy link
Contributor Author

@mxinden This is ready for a re-review. I think I've ironed out the flakiness.

@thomaseizinger thomaseizinger mentioned this pull request Oct 25, 2023
Closed
@mergify mergify bot merged commit def98eb into master Oct 25, 2023
72 checks passed
@mergify mergify bot deleted the feat/hole-punching-tests branch October 25, 2023 10:41
@thomaseizinger thomaseizinger mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.