Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint は v9 へのバージョンアップの準備ができていないので、当面の間は対象外とする。 #29

Merged
merged 3 commits into from
Apr 22, 2024
Merged

ESLint は v9 へのバージョンアップの準備ができていないので、当面の間は対象外とする。 #29

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e94434
reg-suit を使用しているプロダクトはなくなったため除外する
s-sasaki-0529 Apr 22, 2024
9f35ae6
ESLint は v9 へのバージョンアップの準備が出来ていないので無視する
s-sasaki-0529 Apr 22, 2024
09a87f5
description フィールドを追加する
s-sasaki-0529 Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,25 +28,8 @@
"automerge": true
},
{
"groupName": "ESLint and Prettier",
"matchPackageNames": [
"eslint",
"prettier"
],
"matchPackagePatterns": [
"^eslint-",
"^prettier-"
]
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint v9 の準備ができるまでは、グルーピングしていた eslint 系パッケージと Prettier は単独でバージョンアップするようにします。

{
"groupName": "reg-suit",
"matchPackageNames": [
"reg-suit",
"storycap"
],
"matchPackagePatterns": [
"^reg-"
]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ついでですが、既に reg-suit は社内で使われておらず chromatic に統一されてるので削除しちゃいます。

"matchPackageNames": ["eslint"],
"enabled": false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint は問答無用で対象外に。
JSON なので意図のコメントを書けないのが辛い。

Copy link

@mkmn mkmn Apr 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description fieldが使えると思います。
https://docs.renovatebot.com/configuration-options/#description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

便利！
コメント入れときます！

}
]
}
Expand Down
Loading