ESLint は v9 へのバージョンアップの準備ができていないので、当面の間は対象外とする。 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-sasaki-0529
commented
Apr 22, 2024
| "^eslint-", | ||
| "^prettier-" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
ESLint v9 の準備ができるまでは、グルーピングしていた eslint 系パッケージと Prettier は単独でバージョンアップするようにします。
| ], | ||
| "matchPackagePatterns": [ | ||
| "^reg-" | ||
| ] |
There was a problem hiding this comment.
ついでですが、既に reg-suit は社内で使われておらず chromatic に統一されてるので削除しちゃいます。
default.json
Outdated
| "^reg-" | ||
| ] | ||
| "matchPackageNames": ["eslint"], | ||
| "enabled": false |
There was a problem hiding this comment.
eslint は問答無用で対象外に。
JSON なので意図のコメントを書けないのが辛い。
There was a problem hiding this comment.
description fieldが使えると思います。
https://docs.renovatebot.com/configuration-options/#description
There was a problem hiding this comment.
便利！
コメント入れときます！
s-sasaki-0529
requested review from
a team,
ytakahashi05 and
goiso5
and removed request for
a team
ytakahashi05
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
enabled フィールドの使い方を確認して、問題なさそうなのでapproveします🍎
https://docs.renovatebot.com/configuration-options/#enabled
リマインドも設定されているので、設定を戻し忘れることもなさそう 👍
https://kufuinc.slack.com/archives/CJEUZ4MS6/p1713424676743249
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint は v9 から flat config がデフォルト化しますが、typescript-eslint を始めとする各種プラグインの対応が出揃わないとバージョンアップするメリットがないため、それまでの間は renovate の対象外とします。