-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint は v9 へのバージョンアップの準備ができていないので、当面の間は対象外とする。 #29
Conversation
"^eslint-", | ||
"^prettier-" | ||
] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint v9 の準備ができるまでは、グルーピングしていた eslint 系パッケージと Prettier は単独でバージョンアップするようにします。
], | ||
"matchPackagePatterns": [ | ||
"^reg-" | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ついでですが、既に reg-suit は社内で使われておらず chromatic に統一されてるので削除しちゃいます。
default.json
Outdated
"^reg-" | ||
] | ||
"matchPackageNames": ["eslint"], | ||
"enabled": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint は問答無用で対象外に。
JSON なので意図のコメントを書けないのが辛い。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description
fieldが使えると思います。
https://docs.renovatebot.com/configuration-options/#description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
便利!
コメント入れときます!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enabled
フィールドの使い方を確認して、問題なさそうなのでapproveします🍎
https://docs.renovatebot.com/configuration-options/#enabled
リマインドも設定されているので、設定を戻し忘れることもなさそう 👍
https://kufuinc.slack.com/archives/CJEUZ4MS6/p1713424676743249
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
よさそうでした!
ESLint は v9 から flat config がデフォルト化しますが、typescript-eslint を始めとする各種プラグインの対応が出揃わないとバージョンアップするメリットがないため、それまでの間は renovate の対象外とします。