Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): Parameterizing v2 Launcher Image. Resolves #1358 #1359

Merged
merged 1 commit into from
Oct 4, 2023
Merged

feat(backend): Parameterizing v2 Launcher Image. Resolves #1358 #1359

merged 1 commit into from
Oct 4, 2023

Conversation

DharmitD
Copy link

@DharmitD DharmitD commented Oct 4, 2023

Which issue is resolved by this Pull Request:
Resolves #1358

Description of your changes:
Parameterizing the v2 launcher image so it's possible to extend/provide fixes to the code.
Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@google-cla
Copy link

google-cla bot commented Oct 4, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-prow google-oss-prow bot requested review from Tomcli and yhwang October 4, 2023 16:04
Copy link
Member

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DharmitD, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yhwang
Copy link
Member

yhwang commented Oct 4, 2023

thanks for the PR. It's a nice feature to have and I wanted to add this before. Thanks again for your contribution. Please check the CLA and I believe it will be good to go.

@google-oss-prow google-oss-prow bot merged commit ec56e80 into kubeflow:v2-integration Oct 4, 2023
3 checks passed
@DharmitD
Copy link
Author

DharmitD commented Oct 4, 2023

Thank you for reviewing the PR, @yhwang !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants