-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend): Parameterizing v2 Launcher Image. Resolves #1358 #1359
feat(backend): Parameterizing v2 Launcher Image. Resolves #1358 #1359
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DharmitD, yhwang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks for the PR. It's a nice feature to have and I wanted to add this before. Thanks again for your contribution. Please check the CLA and I believe it will be good to go. |
Thank you for reviewing the PR, @yhwang ! |
Which issue is resolved by this Pull Request:
Resolves #1358
Description of your changes:
Parameterizing the v2 launcher image so it's possible to extend/provide fixes to the code.
Environment tested:
python --version
):tkn version
):kubectl version
):/etc/os-release
):Checklist: