Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DharmitD as member #630

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

DharmitD
Copy link
Contributor

@DharmitD DharmitD commented Jan 2, 2024

Refer to #629

Contributed issues:
kubeflow/kfp-tekton#1359
kubeflow/pipelines#10269

pytest output:

(base) [ddalvi@localhost github-orgs]$ pytest test_org_yaml.py
============================================================================================================ test session starts =============================================================================================================
platform linux -- Python 3.9.9, pytest-6.2.5, py-1.10.0, pluggy-1.0.0
rootdir: /home/ddalvi/kubeflow-community/internal-acls/github-orgs
collected 1 item                                                                                                                                                                                                                             

test_org_yaml.py .                                                                                                                                                                                                                     [100%]

============================================================================================================= 1 passed in 0.20s ==============================================================================================================
(base) [ddalvi@localhost github-orgs]$ 

Copy link

Hi @DharmitD. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@terrytangyuan
Copy link
Member

/cc @chensun

@Tomcli
Copy link
Member

Tomcli commented Jan 2, 2024

/lgtm

@zijianjoy
Copy link
Contributor

/approve

Welcome to the community! @DharmitD

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DharmitD, terrytangyuan, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 0d384d1 into kubeflow:master Jan 2, 2024
3 checks passed
@DharmitD
Copy link
Contributor Author

DharmitD commented Jan 2, 2024

Thank you @terrytangyuan @Tomcli @zijianjoy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants