Add validation for Update Results API Params #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: saakhan <[email protected]>
Signed-off-by: saakhan <[email protected]>
… a new method Signed-off-by: saakhan <[email protected]>
|
@khansaad - As discussed, please update the expected error messages in the negative functional tests |
rbadagandi1
modified the milestones:
Kruize 0.0.16_rm Release,
Kruize 0.0.17_rm Release
…-exp-json # Conflicts: # src/main/java/com/autotune/analyzer/serviceObjects/Converters.java # src/main/java/com/autotune/analyzer/services/UpdateResults.java # src/main/java/com/autotune/analyzer/utils/AnalyzerErrorConstants.java
khansaad
changed the title
…ion method Signed-off-by: saakhan <[email protected]>
Signed-off-by: saakhan <[email protected]>
chandrams
reviewed
Nov 2, 2023
| public static final String MEASUREMENT_DURATION_ERROR = "Interval duration cannot be less than or greater than measurement_duration by more than " + KruizeConstants.TimeConv.MEASUREMENT_DURATION_THRESHOLD_SECONDS + " seconds"; | ||
| public static final String MISSING_METRICS = "Metric data is not present for container : %s for experiment: %s. "; | ||
| public static final String BLANK_AGGREGATION_INFO_VALUE = " cannot be negative or blank for the metric variable: "; |
There was a problem hiding this comment.
Please update the tests with the expected error messages validation
|
@khansaad - Please raise a separate PR with the test changes as this PR is closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #561 . It contains validation for the update results API's input params.