Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate blank/null/invalid values for keys in updateResults json #561

Closed
chandrams opened this issue Feb 9, 2023 · 2 comments · Fixed by #814 or #1057
Closed

Validate blank/null/invalid values for keys in updateResults json #561

chandrams opened this issue Feb 9, 2023 · 2 comments · Fixed by #814 or #1057
Assignees
@khansaad
Labels
bug Something isn't working must_fix
Milestone
Kruize 0.0.20.2_r...

Comments

@chandrams
Copy link
Contributor

chandrams commented Feb 9, 2023 •
edited
Loading

Validate blank/null/invalid values for keys in updateResults json and return appropriate error messages

For example, updateResults API returns 201 on passing blank or invalid values to memoryRSS units or memoryRSS max
@chandrams chandrams added bug Something isn't working and removed test labels Mar 16, 2023
@chandrams chandrams added this to the Kruize 0.0.12_rm Release milestone Mar 16, 2023
@dinogun dinogun moved this to Todo in Monitoring Mar 17, 2023
@rbadagandi rbadagandi removed this from the Kruize 0.0.13_rm Release milestone Apr 4, 2023
@rbadagandi rbadagandi added this to the Kruize 0.0.13_rm Release milestone Apr 11, 2023
@khansaad khansaad moved this from Todo to In Progress in Monitoring Apr 13, 2023
@khansaad khansaad mentioned this issue Apr 14, 2023
Closed
@khansaad khansaad linked a pull request Apr 14, 2023 that will close this issue
Create Experiment validation for mandatory params #745
Closed
@khansaad khansaad removed a link to a pull request Apr 18, 2023
Create Experiment validation for mandatory params #745
Closed
@chandrams chandrams mentioned this issue Apr 21, 2023
Closed
@khansaad khansaad mentioned this issue May 9, 2023
Merged
@khansaad khansaad linked a pull request May 16, 2023 that will close this issue
Add validation for Update Results API Params #814
Merged
@rbadagandi rbadagandi mentioned this issue May 16, 2023
Open
@dinogun dinogun removed this from the Kruize 0.0.17_rm Release milestone Jul 7, 2023
@dinogun dinogun added this to the Kruize 0.0.19_rm Release milestone Jul 7, 2023
@rbadagandi1 rbadagandi1 removed this from the Kruize 0.0.19_rm Release milestone Aug 29, 2023
@chandrams chandrams added this to the Kruize 0.0.20_rm Release milestone Sep 21, 2023
@rbadagandi1
Copy link

@khansaad to raise a different PR for test case execution and assign it to @chandrams for verification. Post which this issue can be closed.

@khansaad khansaad mentioned this issue Nov 23, 2023
Merged
@khansaad khansaad linked a pull request Nov 23, 2023 that will close this issue
Add validations for the UpdateResultsAPI objects #1057
Merged
@rbadagandi1 rbadagandi1 moved this from In Progress to Under Review in Monitoring Jan 18, 2024
@rbadagandi1 rbadagandi1 moved this from Under Review to Ready for merge in Monitoring Jan 25, 2024
@rbadagandi1
Copy link

Merged for 20.2 release for PR 1057

@github-project-automation github-project-automation bot moved this from Ready for merge to Done in Monitoring Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khansaad khansaad

Labels
bug Something isn't working must_fix
Projects
Monitoring
Status: Done
Milestone
Kruize 0.0.20.2_rm Release
5 participants
@dinogun @chandrams @khansaad @rbadagandi @rbadagandi1