Create Experiment validation for mandatory params #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Apr 14, 2023
khansaad
changed the title
|
@khansaad - Please update the negative tests for createExperiment json keys with blank/NULL/invalid with the expected error messages and include assertions for the same in the existing functional tests. |
chandrams
reviewed
May 23, 2023
| @@ -75,10 +75,14 @@ def test_create_exp_invalid_tests(test_name, expected_status_code, version, expe | |||
| data = response.json() | |||
| print(data['message']) | |||
|
|
|||
| keys = test_name.split('_', 1) | |||
| test_name_variable = keys[1] | |||
| INVALID_EXP_NAME_MSG = test_name_variable + NOT_EMPTY_OR_NULL | |||
There was a problem hiding this comment.
@khansaad - I think this will match with all invalid tests too for which the expected error message might be different. Can you please share the result log - report.html for this?
Signed-off-by: saakhan <[email protected]>
Signed-off-by: Saad Khan <[email protected]>
khansaad
force-pushed
the
validate-api-json-keys
branch
from
61ab2f3 to
f5a6558
Compare
|
Closing stale PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #559