Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SUP-38407): [GaTech] [Multistream - V7 Player] Child entries not loading high quality flavor assets #793

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

Tzipi-kaltura
Copy link
Contributor

@Tzipi-kaltura Tzipi-kaltura commented Sep 11, 2024

Description of the Changes

Add function to change quality on child entries in dual screen.

part of - kaltura/playkit-js-dual-screen#155

solves SUP-38407

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Tzipi-kaltura Tzipi-kaltura merged commit 89f2b53 into master Sep 11, 2024
11 checks passed
Tzipi-kaltura added a commit that referenced this pull request Sep 15, 2024
…loading high quality flavor assets (#794)

rename function from - #793
part of - kaltura/playkit-js-dual-screen#155
Tzipi-kaltura added a commit to kaltura/playkit-js-dual-screen that referenced this pull request Sep 15, 2024
…loading high quality flavor assets (#155)

Issue:
Quality is not changed in childe entries when it is changed in the parent entry.

Fix:
Add listener to videotrackchange and change the quality manually to all the other entries.

part of - kaltura/playkit-js#793, kaltura/kaltura-player-js#851

solves SUP-38407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants