fix(SUP-38407): [GaTech] [Multistream - V7 Player] Child entries not loading high quality flavor assets #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loading high quality flavor assets
This was referenced Sep 11, 2024
semarche-kaltura
requested changes
Sep 11, 2024
Tzipi-kaltura
added a commit
to kaltura/playkit-js
that referenced
this pull request
Sep 11, 2024
…loading high quality flavor assets (#793) Add function to change quality on child entries in dual screen. part of - kaltura/playkit-js-dual-screen#155 solves SUP-38407
semarche-kaltura
approved these changes
Sep 11, 2024
5 tasks
Tzipi-kaltura
added a commit
to kaltura/playkit-js
that referenced
this pull request
Sep 15, 2024
…loading high quality flavor assets (#794) rename function from - #793 part of - kaltura/playkit-js-dual-screen#155
MosheMaorKaltura
approved these changes
Sep 15, 2024
MosheMaorKaltura
pushed a commit
to kaltura/kaltura-player-js
that referenced
this pull request
Sep 15, 2024
…loading high quality flavor assets (#851) ### Description of the Changes Please add a detailed description of the change, whether it's an enhancement or a bugfix. If the PR is related to an open issue please link to it. export changeChildQuality function part of - https://github.com/kaltura/playkit-js/pull/793/files, kaltura/playkit-js-dual-screen#155 #### Resolves [SUP-38407](https://kaltura.atlassian.net/browse/SUP-38407) [SUP-38407]: https://kaltura.atlassian.net/browse/SUP-38407?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Quality is not changed in childe entries when it is changed in the parent entry.
Fix:
Add listener to videotrackchange and change the quality manually to all the other entries.
part of - kaltura/playkit-js#793, kaltura/kaltura-player-js#851
solves SUP-38407