Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SUP-43040): v7 player issues when using picture-in-picture (pop-out) #782

Merged
merged 2 commits into from
Jun 18, 2024
Merged

fix(SUP-43040): v7 player issues when using picture-in-picture (pop-out) #782

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff5222b
fix(SUP-43040): v7 player issues when using picture-in-picture (pop-out)
Tzipi-kaltura Jun 9, 2024
a456dfc
change order
Tzipi-kaltura Jun 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/engines/html5/html5.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ export default class Html5 extends FakeEventTarget implements IEngine {
// Currently it's supported in chrome and in safari. So if we consider checking support before,
// we can use this flag to distinguish between the two. In the future we might need a different method.
// Second condition is because flow does not support this API yet
if (document.pictureInPictureEnabled && typeof this._el.requestPictureInPicture === 'function') {
if (document.pictureInPictureEnabled && typeof this._el.requestPictureInPicture === 'function' && !this._el.disablePictureInPicture) {
this._el.requestPictureInPicture().catch(error => {
this.dispatchEvent(
new FakeEvent(
Expand Down
Loading