Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SUP-43040): v7 player issues when using picture-in-picture (pop-out) #782

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

Tzipi-kaltura
Copy link
Contributor

@Tzipi-kaltura Tzipi-kaltura commented Jun 9, 2024

Description of the Changes

Issue:
In dual screen player the pip option is disabled by adding disablePictureInPicture on the video element. was done here - FEC-13591.
As a result from that when clicking on the pip button error is thrown and the video is frozen

Solution:
Call to pip function only if disablePictureInPicture is not true

Solves SUP-43040

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Tzipi-kaltura Tzipi-kaltura merged commit 16e2d47 into master Jun 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants