Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ADA-1734): Continues ADA-1500, Added Localizer+Text+Translates #95

Conversation

RazvanBrinzoiK05
Copy link
Contributor

@RazvanBrinzoiK05 RazvanBrinzoiK05 commented Sep 27, 2024

With:
kaltura/playkit-js-ui-managers#64

Issue::
Previous JSX was not translated when loaded in the ui-managers
This plugin had no translates and that's why it was not rendered [Object object].
Now that we can support translates for all plugins, I considered to add it for moderation as well.

Fix:
Used Text component instead of plain text for translation

@@ -1,6 +1,7 @@
{
"en": {
"moderation": {
"moderation": "Moderation",
Copy link
Contributor

@SivanA-Kaltura SivanA-Kaltura Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is a new text, please make a ticket regarding it requiring a translation, and link it to Sagi.
once the translations are ready we will add them in the other i18n files here.
just to be clear, it will be in a separate PR. for now, we just want to track that there is a new text that needs translation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good ok, than I will link this to Sagi

RazvanBrinzoiK05 added a commit to kaltura/playkit-js-ui-managers that referenced this pull request Nov 4, 2024
**With:**
kaltura/playkit-js-moderation#95

**Issue:**:
Previous JSX was not translated when loaded in the ui-managers
This was causing aria-label to be rendered: [Object object]:

![image](https://github.com/user-attachments/assets/aecff15e-77a8-4534-96cb-e258e7bc5319)

 
**Fix**:
Used "preact-render-to-string" library to convert the JSX to string
@RazvanBrinzoiK05
Copy link
Contributor Author

Sagi answered and I will close this PR, opening this one updated with Sagi input: #98

@RazvanBrinzoiK05
Copy link
Contributor Author

#98

RazvanBrinzoiK05 added a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants