fix(ADA-1734): Continues ADA-1500, Added Localizer #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RazvanBrinzoiK05
requested review from
semarche-kaltura,
lianbenjamin and
SivanA-Kaltura
This was referenced Sep 27, 2024
Closed
fix(ADA-1734): Continues ADA-1500, Converting JSX labels to string
kaltura/playkit-js-ui-managers#63
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With:
Other Plugins involved:
fix(ADA-1734): Continues ADA-1500, Added Localizer playkit-js-share#54
fix(ADA-1734): Continues ADA-1500, Added Localizer playkit-js-info#104
fix(ADA-1734): Continues ADA-1500, Added Localizer+Text+Translates playkit-js-moderation#95
For JSX conversion is required this PR that adds "preact-render-to-string" library:
Issue::
Previous JSX was not translated when loaded in the ui-managers
This was causing aria-label to be rendered: [Object object]
Fix:
For translation added Localizer component as well