Add ArchLinux support #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdii
force-pushed
the
add-archlinux-support
branch
from
420a3ea to
08887aa
Compare
kke
reviewed
Aug 10, 2021
os/linux/archlinux.go
Outdated
| ) | ||
|
|
||
| // ArchlinuxARM provides OS support for ArchlinuxARM systems | ||
| type ArchlinuxARM struct { |
There was a problem hiding this comment.
Probably should just be ArchLinux as it will be detected as well and things here should work with the non-arm arch as well.
kke
reviewed
Aug 10, 2021
os/linux/archlinux.go
Outdated
|
|
||
| // InstallPackage installs packages via pacman | ||
| func (c ArchlinuxARM) InstallPackage(h os.Host, s ...string) error { | ||
| return h.Execf("pacman -S --noconfirm %s", strings.Join(s, " ")) |
There was a problem hiding this comment.
Needs sudo, maybe add --noprogressbar to get a bit cleaner log output.
Suggested change
| return h.Execf("pacman -S --noconfirm %s", strings.Join(s, " ")) | |
| return h.Execf("sudo pacman -S --noconfirm --noprogressbar %s", strings.Join(s, " ")) |
kke
reviewed
Aug 10, 2021
resolver.go
Outdated
Comment on lines
126
to
131
| versionNeeded := true | ||
| if os.IDLike == "arch" { | ||
| versionNeeded = false | ||
| } | ||
|
|
||
| if os.ID == "" || (versionNeeded && os.Version == "") { |
There was a problem hiding this comment.
I think a more future proof solution would be to change the switch-case thing above to set the version to something like 0.0.0.
case "ID_LIKE":
os.IDLike = unquote(fields[1])
if os.IDLike == "arch" {
os.Version = "0.0.0"
}
Signed-off-by: erdii <[email protected]>
erdii
force-pushed
the
add-archlinux-support
branch
from
08887aa to
f0ba043
Compare
|
Heyo @kke 👋 |
kke
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sibling PR: k0sproject/k0sctl#183