Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ArchLinux support #183

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Add ArchLinux support #183

merged 2 commits into from
Aug 11, 2021

Conversation

erdii
Copy link
Contributor

@erdii erdii commented Aug 9, 2021

add support to deploy on archlinux nodes
tested on archlinuxarm (together with #184)

sibling PR: k0sproject/rig#33

@erdii erdii force-pushed the add-archlinux-support branch from ce271f7 to 92ae1b0 Compare August 9, 2021 16:47
@erdii erdii marked this pull request as ready for review August 9, 2021 17:03
@erdii erdii changed the title Add archlinux support add archlinux support Aug 9, 2021
@erdii erdii force-pushed the add-archlinux-support branch from 92ae1b0 to 0d0471d Compare August 9, 2021 22:02
)

// ArchlinuxARM provides OS support for ArchlinuxARM systems
type ArchlinuxARM struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be just ArchLinux as it will detect non-arm Arch as well.

@@ -379,6 +379,22 @@ func (h *Host) NeedIPTables() bool {
return !h.Configurer.CommandExist(h, "iptables")
}

// NeedInetUtils returns true when the inetutils package is needed on the host to run `hostname`.
// Placing this check here is kind of meh because this package probably only exists on arch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the inetutils package exists on most distros but it'spre-installed on almost all of them. Installing it when hostname is missing may actually solve some rare issues for other distros.

@kke kke changed the title add archlinux support Add ArchLinux support Aug 10, 2021
@erdii erdii force-pushed the add-archlinux-support branch from 0d0471d to 172d9fd Compare August 10, 2021 08:28
@erdii
Copy link
Contributor Author

erdii commented Aug 10, 2021

Heyo @kke 👋
Good catches! I've (again! 😀) incorporated all of your suggestions. :)

@kke
Copy link
Contributor

kke commented Aug 10, 2021

You can now update the go.mod to use rig 0.3.23 to get the rig side of things.

@erdii
Copy link
Contributor Author

erdii commented Aug 10, 2021

Done! 👍

@kke kke merged commit 7509758 into k0sproject:main Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants