Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve winrm channel close panic recovery workaround #215

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

kke
Copy link
Contributor

@kke kke commented Aug 6, 2024

Looks like #209 wasn't enough as seen in this workflow failure: https://github.com/k0sproject/rig/actions/runs/10193510624/job/28198254766?pr=213#step:6:643

This adds additional recovers for the stdout/stderr read loops which run in a different goroutine.

@kke kke added bug Something isn't working enhancement New feature or request labels Aug 6, 2024
@kke kke merged commit c46cde3 into release-0.x Aug 6, 2024
6 of 7 checks passed
@kke kke deleted the fix-channel-close-panic-recover branch August 6, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant