Improve winrm channel close panic recovery workaround (#215)

Signed-off-by: Kimmo Lehto <[email protected]>
k0sproject · Aug 6, 2024 · c46cde3 · c46cde3
1 parent a01379f
commit c46cde3
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/winrm.go b/winrm.go
@@ -321,6 +321,12 @@ func (c *WinRM) Exec(cmd string, opts ...exec.Option) error { //nolint:cyclop
 
 	wg.Add(1)
 	go func() {
+		// ignore channel close panics
+		defer func() {
+			if r := recover(); r != nil {
+				log.Debugf("recovered from a panic while reading stderr: %v", r)
+			}
+		}()
 		defer wg.Done()
 		if execOpts.Writer == nil {
 			outputScanner := bufio.NewScanner(command.Stdout)
@@ -344,6 +350,12 @@ func (c *WinRM) Exec(cmd string, opts ...exec.Option) error { //nolint:cyclop
 
 	wg.Add(1)
 	go func() {
+		// ignore channel close panics
+		defer func() {
+			if r := recover(); r != nil {
+				log.Debugf("recovered from a panic while reading stderr: %v", r)
+			}
+		}()
 		defer wg.Done()
 		outputScanner := bufio.NewScanner(command.Stderr)