[jsk_robot_startup] Combine two if to one

jsk-ros-pkg · Feb 10, 2023 · 1b43763 · 1b43763
1 parent 0273e68
commit 1b43763
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/jsk_robot_common/jsk_robot_startup/scripts/smach_to_mail.py b/jsk_robot_common/jsk_robot_startup/scripts/smach_to_mail.py
@@ -182,12 +182,13 @@ def _status_cb(self, msg):
         else:
             self.smach_state_list[caller_id].append(status_dict)
 
-        if self.send_every_transition:
-            if (self.use_google_chat
-                    and not self.smach_state_list[caller_id] is None):
-                rospy.loginfo("Send every transition called")
-                self._send_google_chat(
-                    self.smach_state_subject[caller_id], [status_dict])
+        # send notification every transition
+        if (self.send_every_transition
+                and self.use_google_chat
+                and not self.smach_state_list[caller_id] is None):
+            rospy.loginfo("Send every transition called")
+            self._send_google_chat(
+                self.smach_state_subject[caller_id], [status_dict])
 
         # If we received END/FINISH status, send email, etc...
         if status_str in ["END", "FINISH", "FINISH-SUCCESS", "FINISH-FAILURE"]: