-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsk_footstep_planner] add more args to optimistic_footstep_planner #755
Open
Naoki-Hiraoka
wants to merge
4
commits into
jsk-ros-pkg:master
Choose a base branch
from
Naoki-Hiraoka:add-arg-optimisic-planner
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[jsk_footstep_planner] add more args to optimistic_footstep_planner #755
Naoki-Hiraoka
wants to merge
4
commits into
jsk-ros-pkg:master
from
Naoki-Hiraoka:add-arg-optimisic-planner
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-okada
requested changes
Sep 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test failing, wrong ~obstacle_model
parameters?
<testsuite tests="8" failures="3" disabled="0" errors="0" time="37" name="AllTests">
<testcase name="all-test" status="run" time="0" classname="all-test">
</testcase>
<testcase name="test-sample-init" status="run" time="8" classname="test-sample-init">
</testcase>
<testcase name="test-sample-without-obstacle" status="run" time="0" classname="test-sample-without-obstacle">
<failure message="" type="AssertionError">
Test:(progn (publish-footstep-planning-obstacle-model-from-eus-pointcloud (instance pointcloud :init)) (let* ((result (plan-footstep-from-goal-coords (make-coords :pos (float-vector 3000 0 0))))) (and result (footstep-array->coords result))))
Trace:"^[0mmstart testing [test-sample-without-obstacle]
ld/jsk_footstep_planner/test_results/jsk_footstep_planner/rosunit-test_footste"
Message:""
</failure>
</testcase>
<testcase name="test-sample-with-obstacle-1" status="run" time="0" classname="test-sample-with-obstacle-1">
<failure message="" type="AssertionError">
Test:(progn (let ((obstacle-point-cloud (get-pointcloud-within-bodies-2d (list (let ((bb (make-cube 400 400 50))) (send bb :translate (float-vector 400 0 0)) (send bb :worldcoords) bb))))) (publish-footstep-planning-obstacle-model-from-eus-pointcloud obstacle-point-cloud) (let* ((result (plan-footstep-from-goal-coords (make-coords :pos (float-vector 3000 0 0))))) (and result (footstep-array->coords result)))))
Trace:"^[0mmstart testing [test-sample-with-obstacle-1]
out-obstacle]
ld/jsk_footstep_planner/test_results/jsk_footstep_planner/rosunit"
Message:""
</failure>
</testcase>
<testcase name="test-sample-with-obstacle-2" status="run" time="10" classname="test-sample-with-obstacle-2">
<failure message="" type="AssertionError">
Test:(progn (load "models/room73b2-scene") (objects (list (room73b2))) (let ((obstacle-point-cloud (get-pointcloud-within-bodies-2d (list (send (make-bounding-box (flatten (send-all (send (send *room73b2* :object "room73b2-gifuplastic-900-cart") :bodies) :vertices))) :body))))) (publish-footstep-planning-obstacle-model-from-eus-pointcloud obstacle-point-cloud) (let ((result (plan-footstep-from-goal-coords (send (send (send (send *room73b2* :object "room73b2-gifuplastic-900-cart") :copy-worldcoords) :translate (float-vector -600 -500 0) :world) :rotate pi/2 :z) :start-coords (send (send (send *room73b2* :object "room73b2-gifuplastic-900-cart") :copy-worldcoords) :translate (float-vector 0 300 0) :world)))) (and result (footstep-array->coords result)))))
Trace:"^[0mm;; no display is found. exit from (make-irtviewer)
).^[0m
art testing [test-sample-with-obstacle-1]
out-obstacle]
ld/jsk_fo"
Message:""
</failure>
</testcase>
<testcase name="test-sample-footstep-successors" status="run" time="1" classname="test-sample-footstep-successors">
</testcase>
<testcase name="test-sample-stair-walking-0" status="run" time="13" classname="test-sample-stair-walking-0">
</testcase>
<testcase name="test-sample-stair-walking-1" status="run" time="4" classname="test-sample-stair-walking-1">
</testcase>
<testcase name="test-sample-slope-walking" status="run" time="1" classname="test-sample-slope-walking">
</testcase>
</testsuite>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimistic_footstep_planner.launch
の、点群のトピックの名前を変えられるようにしました。