[Aerial Robot Model][Underactuated][Plugin] fix the wrong args assignment for model constructor #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review this PR. |
|
Can you approve this PR? |
|
Yes, it looks good to me. |
|
I mean, can you complete the review request that I sent to you by clicking the "approve" button? |
sugikazu75
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this
There is a bug while assigning the arg to the variable
fixed_model_while creating the instance for underactuated model.Details
fixed_model_when creating the instance for underactuated model plugin.aerial_robot_model::transformable::RobotModelinstead ofaerial_robot_model::RobotModelfor planning in dragon model and control processes.