Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix installer for npm v10+ #2258

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Fix installer for npm v10+ #2258

merged 2 commits into from
Oct 12, 2023

Conversation

michael-siek
Copy link
Contributor

@michael-siek michael-siek commented Oct 12, 2023 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

@michael-siek michael-siek changed the base branch from v2 to dev October 12, 2023 14:29
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@michael-siek
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Oct 12, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 12, 2023
@yahavi yahavi changed the title fix: support npm v10+ Fix installer for npm v10+ Oct 12, 2023
@yahavi yahavi added the bug Something isn't working label Oct 12, 2023
yahavi
yahavi approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @michael-siek!

@yahavi yahavi merged commit fd191a7 into jfrog:dev Oct 12, 2023
79 of 83 checks passed
@michael-siek
Copy link
Contributor Author

Hey @yahavi do you by chance know when this would be released?

@yahavi
Copy link
Member

yahavi commented Oct 18, 2023

Hey there, Michael-Siek!
We've just released JFrog CLI 2.50.2, and it comes with the fix you contributed. If you require any further assistance, don't hesitate to reach out.

@chenrui333 chenrui333 mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-siek @yahavi