Fix installer for npm v10+ (#2258)

jfrog · Oct 12, 2023 · fd191a7 · fd191a7
1 parent de0e564
commit fd191a7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/build/npm/v2-jf/init.js b/build/npm/v2-jf/init.js
@@ -97,8 +97,8 @@ function isValidNpmVersion() {
     const child_process = require("child_process");
     const npmVersionCmdOut = child_process.execSync("npm version -json");
     const npmVersion = JSON.parse(npmVersionCmdOut).npm;
-    // Supported since version 5.0.0
-    return parseInt(npmVersion.charAt(0)) > 4;
+    // Supported since version 5.0.0 (also support npm v10+)
+    return parseInt(npmVersion.split('.')[0]) > 4;
 }
 
 function writeToFile(response) {
@@ -153,4 +153,4 @@ function getFileName() {
         executable += ".exe";
     }
     return executable;
-}
+}
diff --git a/build/npm/v2/init.js b/build/npm/v2/init.js
@@ -97,8 +97,8 @@ function isValidNpmVersion() {
     const child_process = require("child_process");
     const npmVersionCmdOut = child_process.execSync("npm version -json");
     const npmVersion = JSON.parse(npmVersionCmdOut).npm;
-    // Supported since version 5.0.0
-    return parseInt(npmVersion.charAt(0)) > 4;
+    // Supported since version 5.0.0 (also support npm v10+)
+    return parseInt(npmVersion.split('.')[0]) > 4;
 }
 
 function writeToFile(response) {
@@ -153,4 +153,4 @@ function getFileName() {
         executable += ".exe";
     }
     return executable;
-}
+}