Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build flat dependency trees while auditing Gradle projects #976

Merged
merged 6 commits into from
Oct 2, 2023
Merged

Build flat dependency trees while auditing Gradle projects #976

merged 6 commits into from
Oct 2, 2023

Conversation

asafgabai
Copy link
Contributor

@asafgabai asafgabai commented Sep 27, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

A new, more memory-efficient structure for the dependency trees of Gradle projects.

@asafgabai asafgabai added the improvement Automatically generated release notes label Sep 27, 2023
@asafgabai asafgabai mentioned this pull request Sep 28, 2023
Closed
@asafgabai asafgabai linked an issue Sep 28, 2023 that may be closed by this pull request
Bump gradle-dep-tree dependency to 3.0.0 #853
Closed
@asafgabai asafgabai mentioned this pull request Sep 28, 2023
Open
@asafgabai asafgabai marked this pull request as ready for review September 28, 2023 11:23
@asafgabai asafgabai requested a review from yahavi September 28, 2023 11:24
@asafgabai asafgabai temporarily deployed to frogbot October 1, 2023 06:18 — with GitHub Actions Inactive
yahavi
yahavi requested changes Oct 1, 2023
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top-level @asafgabai!
Please consider my inline comments.

xray/commands/audit/sca/java/javautils.go Show resolved Hide resolved
xray/commands/audit/sca/java/javautils.go Show resolved Hide resolved
xray/commands/audit/sca/java/javautils.go Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2023

@asafgabai asafgabai merged commit 672e903 into jfrog:dev Oct 2, 2023
7 of 8 checks passed
@asafgabai asafgabai deleted the gradle-dep-tree-upgrade branch October 2, 2023 08:32
@ZhongRuoyu ZhongRuoyu mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump gradle-dep-tree dependency to 3.0.0
2 participants
@asafgabai @yahavi