rollup of many fixes and improvements, windows-compatible #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earonesty
commented
Feb 27, 2023
| @@ -58,10 +59,6 @@ def bech32(self) -> str: | |||
| def hex(self) -> str: | |||
| return self.raw_secret.hex() | |||
|
|
|||
| def tweak_add(self, scalar: bytes) -> bytes: | |||
There was a problem hiding this comment.
got rid of this because it's not used, and not tested
|
I already done the work, check https://github.com/holgern/pynostr |
|
Please see also #52 |
|
yeah, i realized that later. but your fork is very far behind master, and it makes a lot more changes to the code. nicer to have it all in one place, and just import a different module... no code change to the main. now i can maintain the fork with no effort, or even switch to embit easily |
|
is there any way to install this via pip? |
|
seriously considering just releasing this separately to pypi |
earonesty
commented
Jul 30, 2023
| @@ -51,17 +52,18 @@ def from_nsec(cls, nsec: str): | |||
| raw_secret = bech32.convertbits(data, 5, 8)[:-1] | |||
| return cls(bytes(raw_secret)) | |||
|
|
|||
| @classmethod | |||
| def from_hex(cls, hex: str): | |||
earonesty
commented
Jul 30, 2023
| @@ -34,7 +34,7 @@ class RelayProxyConnectionConfig: | |||
| class Relay: | |||
| url: str | |||
| message_pool: MessagePool | |||
| policy: RelayPolicy = RelayPolicy() | |||
| policy: RelayPolicy = field(default_factory=RelayPolicy) | |||
earonesty
changed the title
earonesty
changed the title
earonesty
commented
Jul 30, 2023
| def to_message(self) -> str: | ||
| return json.dumps( | ||
| [ | ||
| def to_json(self) -> list: |
earonesty
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the fork im using