Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jax.nn.one_hot: deprecate non-integer inputs #25590

Merged
merged 1 commit into from
Dec 19, 2024
Merged

jax.nn.one_hot: deprecate non-integer inputs #25590

merged 1 commit into from
Dec 19, 2024
+34 −15

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Dec 18, 2024

Fixes #25484

@jakevdp jakevdp self-assigned this Dec 18, 2024
@jakevdp jakevdp added the pull ready Ready for copybara import and testing label Dec 18, 2024
@jakevdp jakevdp requested a review from yashk2810 December 18, 2024 22:40
@copybara-service copybara-service bot merged commit 8402a98 into jax-ml:main Dec 19, 2024
22 of 23 checks passed
@jakevdp jakevdp deleted the fix-one-hot-float branch December 19, 2024 17:49
@jakevdp jakevdp mentioned this pull request Dec 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashk2810 yashk2810 yashk2810 approved these changes

Assignees

@jakevdp jakevdp

Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jax.nn.one_hot should not allow float inputs
3 participants
@jakevdp @yashk2810 @kokoro-team