Remove casting from jax.nn.one_hot #25669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was made after the most recent release, so is safe to remove. Casting float to int potentially changes intentional beavior: e.g. NaN casts to 0. Some downstream users currently use NaN to mark rows which should have no one-hot entry.
superbobry
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was made after the most recent release, so is safe to remove. Casting float to int potentially changes intentional behavior: e.g. NaN casts to 0. Some downstream users currently use NaN to mark rows which should have no one-hot entry.
Fixes issue introduced in #25590.