Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove core.concrete_aval and replace with abstractify #25555

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Dec 17, 2024

Culmination of the work in #25456, #25534, and #25544.

Because of the work in those PRs, this change should not involve any change of behavior, aside from the deprecations of the now-obsolete APIs.

@jakevdp jakevdp self-assigned this Dec 17, 2024
@jakevdp jakevdp requested a review from yashk2810 December 17, 2024 23:55
Copy link
Collaborator

@yashk2810 yashk2810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo 🚀

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Dec 17, 2024
@jakevdp jakevdp force-pushed the combine-avals branch 3 times, most recently from 007bf36 to e5e062a Compare December 18, 2024 02:16
@copybara-service copybara-service bot merged commit b56dc63 into jax-ml:main Dec 18, 2024
20 of 23 checks passed
@jakevdp jakevdp deleted the combine-avals branch December 18, 2024 03:59
copybara-service bot pushed a commit that referenced this pull request Dec 18, 2024
Reverts 25524ab

PiperOrigin-RevId: 707568893
copybara-service bot pushed a commit that referenced this pull request Dec 18, 2024
Reverts 25524ab

PiperOrigin-RevId: 707568893
copybara-service bot pushed a commit that referenced this pull request Dec 18, 2024
Reverts 25524ab

PiperOrigin-RevId: 707568893
copybara-service bot pushed a commit that referenced this pull request Dec 18, 2024
Reverts 25524ab

PiperOrigin-RevId: 707679094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull ready Ready for copybara import and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants