WIP: no special treatment for ShapeDtypeStruct #25583
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You will need to run TGP to find the real failures. But users pass Last time I looked, the failures were a lot so I didn't really take any action but maybe you can! |
jakevdp
force-pushed
the
fix-shapedtype
branch
from
0bf85ee to
1d15e35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm confused as to why we need to register this, because
ShapeDtypeStructshould behave exactly the same as any duck-typed value with ashapeanddtype.This registration recently led to the rollback of #25555 because a downstream library was relying on this behavior in a dubious way.