Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the deployment of the site version for forks #95

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

JeremyMcCormick
Copy link
Collaborator

Repository secrets are not available on PRs from forks by default and we do not plan to enable this.

Repository secrets are not available on PRs from forks by default and
we do not plan to enable this.
@JeremyMcCormick JeremyMcCormick linked an issue Oct 28, 2024 that may be closed by this pull request
Copy link
Member

@molinaro-m molinaro-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, with my limited knowledge of the technology.
Fork owners will have to preview themselves the changes to keep the website consistent. This will drop the load in securing the ssh needed by versioned previews.
All fine.

@JeremyMcCormick JeremyMcCormick merged commit 9f38ee1 into main Oct 30, 2024
1 check passed
@JeremyMcCormick JeremyMcCormick deleted the iss49-disable-preview-site-from-fork branch October 30, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PRs from forks
2 participants