-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only build preview site for iss
branches
#56
Comments
An alternative would be to create the directory |
iss
branches
It seems more natural to connect the branch versions to issues in the tracker. If a PR resolves multiple issues, it should just use one of them. I really prefer though that issues are scoped in a way that would typically connect them to a single PR, aside from small patches and fixes. Having a PR that resolves multiple issues shouldn't be the typical pattern and I would discourage it. Plus the idea here is that some PRs for small fixes/patches don't need a site version built. So we have to filter on some part of the branch name to do this automatically. |
For now, we'll build the site versions for all branches besides those from forks (covered by #95). |
We could establish a convention that only branches beginning with
iss
trigger the deployment of a branch version of the site. This would avoid clutter in the branch versions directory, especially from branches that don't actually update the site content and only change configuration or documentation.Consequently, any changes beyond the most minor updates to the site, such as fixing spelling mistakes, should have their own issue and branch.
The text was updated successfully, but these errors were encountered: