-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds camera pose getter and local pose setter #1174
base: main
Are you sure you want to change the base?
Conversation
add get local pose
@@ -360,6 +360,31 @@ def test_camera_set_world_poses_from_view(self): | |||
torch.testing.assert_close(camera.data.pos_w, eyes) | |||
torch.testing.assert_close(camera.data.quat_w_ros, quat_ros_gt) | |||
|
|||
def test_camera_get_world_poses(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please also add a unit test for the local pose APIs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the suggestion. I'll add it soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added.
Signed-off-by: Kelly Guo <[email protected]>
if env_ids is None: | ||
env_ids = self._ALL_INDICES | ||
# set camera poses using the view | ||
orientations = quat_from_matrix(create_rotation_matrix_from_view(eyes, targets, device=self._device)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this API also work for local coordinates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it works for local coordinates
add unit tests for local API
Signed-off-by: Hongyu Li <[email protected]>
Thanks for the update! Can you please run the formatter |
Thanks for reminder! I just update the CHANGELOG.rst, extention.toml,and format the repo. |
Description
This change adds local pose getter and setter APIs for the Camera class.
Fixes #1034 (issue)
Type of change
Screenshots
N/A. Only code interface changes.
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there