Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT-6904 Marlowe Runtime fails to create transaction involving ada as the role token #722

Merged
merged 3 commits into from
Sep 28, 2023
Merged

PLT-6904 Marlowe Runtime fails to create transaction involving ada as the role token #722

merged 3 commits into from
Sep 28, 2023

Conversation

jhbertra
Copy link
Contributor

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Test report is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
      • Review required
      • Substantial changes to code, test, or documentation
      • Change made to Marlowe validator (@bwbush and @palas must be included as reviewers)
      • Review not required
      • Minor changes to non-critical code, documentation, nix derivations, configuration files, or scripts
      • Formatting, spelling, grammar, or reorganization
    • Reviewer requested

@jhbertra jhbertra requested a review from bwbush September 27, 2023 21:18
@jhbertra jhbertra self-assigned this Sep 27, 2023
@jhbertra jhbertra changed the base branch from main to plt-7681-next-test-failure September 28, 2023 12:11
Base automatically changed from plt-7681-next-test-failure to main September 28, 2023 16:18
@jhbertra jhbertra force-pushed the plt-6904-ada-role-token branch from 84a48e6 to 5eb2ab1 Compare September 28, 2023 16:18
bwbush
bwbush approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@bwbush bwbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jhbertra jhbertra merged commit b9e32a6 into main Sep 28, 2023
3 checks passed
@jhbertra jhbertra deleted the plt-6904-ada-role-token branch September 28, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwbush bwbush bwbush approved these changes

Assignees

@jhbertra jhbertra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhbertra @bwbush